Skip to content

🌱 Fix(ignition): Default version only if not storageType UnencryptedUserData #5641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

🌱 Fix(ignition): Default version only if not storageType UnencryptedUserData #5641

merged 1 commit into from
Sep 3, 2025

Conversation

chrischdi
Copy link
Member

/kind feature

What this PR does / why we need it:

The ignition version on AWSMachine's and AWSMachinePool's is not used when having storageType set to UnencryptedUserData.

Because of that, defaulting to 2.3 could be misleading.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

This PR relaxes the defaulting (which happened in openapi and in the webhook) and only defaults via the webhook if the storageType is not set to UnencryptedUserData.

This PR also improves the description of the field.

Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Disable defaulting for .spec.ignition.version when `.spec.ignition.storageType` is set to `UnencryptedUserData`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. needs-priority labels Sep 2, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2025
@chrischdi chrischdi changed the title 🌱 Fix(ignition): Default version only if not storageType UnencryptedUserData [Draft] 🌱 Fix(ignition): Default version only if not storageType UnencryptedUserData Sep 2, 2025
@chrischdi chrischdi changed the title [Draft] 🌱 Fix(ignition): Default version only if not storageType UnencryptedUserData [WIP] 🌱 Fix(ignition): Default version only if not storageType UnencryptedUserData Sep 2, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2025
damdo
damdo reviewed Sep 2, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrischdi thanks a lot for your PR 🎉
A couple of nits, but looks good to me

@chrischdi chrischdi force-pushed the pr-ignition-version-optional-for-unencrypted branch from c3682fc to 6b94143 Compare September 2, 2025 15:43
damdo
damdo reviewed Sep 2, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my nits

/lgtm

/assign @nrb @richardcase @AndiDog @dlipovetsky

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1adfba57986f1ae4abdd7e151ee67bf58b43c0ef

@chrischdi chrischdi changed the title [WIP] 🌱 Fix(ignition): Default version only if not storageType UnencryptedUserData 🌱 Fix(ignition): Default version only if not storageType UnencryptedUserData Sep 2, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2025
@theobarberbany
Copy link
Contributor

/lgtm

@AndiDog
Copy link
Contributor

AndiDog commented Sep 3, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndiDog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0eb6d7f into kubernetes-sigs:main Sep 3, 2025
21 checks passed
@damdo
Copy link
Member

damdo commented Sep 3, 2025

/cherry-pick release-2.9

@k8s-infra-cherrypick-robot
Copy link

@damdo: new pull request created: #5644

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Sep 3, 2025
Merged
This was referenced Sep 4, 2025
Closed
Merged
@chrischdi chrischdi mentioned this pull request Sep 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo damdo left review comments

@AndiDog AndiDog Awaiting requested review from AndiDog

@luthermonson luthermonson Awaiting requested review from luthermonson

Assignees

@richardcase richardcase

@nrb nrb

@AndiDog AndiDog

@dlipovetsky dlipovetsky

@damdo damdo

@theobarberbany theobarberbany

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@chrischdi @k8s-ci-robot @theobarberbany @AndiDog @damdo @k8s-infra-cherrypick-robot @richardcase @nrb @dlipovetsky